feat(evaluation): support scenario file references - #1696
Merged
Conversation
christso
marked this pull request as ready for review
July 6, 2026 08:12
Deploying agentv with
|
| Latest commit: |
253aa6d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d3ac008.agentv.pages.dev |
| Branch Preview URL: | https://examples-av-7bnx-scenarios.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scenariosfile refs/globs and flatten them before scenario lowering.examples/features/scenarioswith inline plus glob-loaded translation scenarios and a deterministic local CLI target.Validation
bun installbun apps/cli/src/cli.ts validate <tmp scenario eval>rejectedscenarios[0]with "Scenario must be an object".bun --filter @agentv/core buildbun apps/cli/src/cli.ts validate examples/features/scenarios/evals/suite.yaml-> valid 1 / invalid 0bun run validate:examples-> 109 valid / 0 invalidbun apps/cli/src/cli.ts eval run examples/features/scenarios/evals/suite.yaml --targets examples/features/scenarios/targets.yaml --target translation-cli --output /tmp/agentv-scenarios-run-LjjGCq-> PASS, 4/4 scored 100%inline-portuguese-hello,french-hello,spanish-hello-world,spanish-thank-you, all statusok, score 1bun run lintbun --filter @agentv/core test test/evaluation/loaders/jsonl-parser.test.ts test/evaluation/validation/eval-validator.test.ts test/evaluation/validation/eval-file-schema.test.ts test/evaluation/validation/eval-schema-sync.test.ts-> 217 pass / 0 failNotes
scenarios; it does not add universal arbitrary-field file expansion.providerPromptMap, scenario result grouping, artifact primitive, or Dashboard behavior changes.